Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self-signed certificates: Add CN as subjectAltName #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

self-signed certificates: Add CN as subjectAltName #113

wants to merge 1 commit into from

Conversation

fhessel
Copy link
Owner

@fhessel fhessel commented Jan 23, 2021

When creating self-signed certificates, add the CN in the subjectAltName extension so browsers stop complaining.

References:

@fhessel fhessel mentioned this pull request Jan 23, 2021
Open
@fhessel fhessel added the CI: Build Examples When set, the examples will be built for this PR label Jan 23, 2021
@github-actions github-actions bot removed the CI: Build Examples When set, the examples will be built for this PR label Jan 23, 2021
@fhessel fhessel added the CI: Build Examples When set, the examples will be built for this PR label Jan 23, 2021
@github-actions github-actions bot removed the CI: Build Examples When set, the examples will be built for this PR label Jan 23, 2021
@amandel amandel mentioned this pull request May 18, 2021
Closed
5 tasks
amandel
amandel approved these changes May 29, 2021
View reviewed changes
Copy link

@amandel amandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I was hoping to get some feedback from Mac Users about the use of the "new" cert, but this seem to take more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandel amandel amandel approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fhessel @amandel