Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Video by URL #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Load Video by URL #71

wants to merge 1 commit into from

Conversation

WilHolt
Copy link

@WilHolt WilHolt commented May 24, 2021

This feature allow us to load video passing videoId or use any youtube url format to load videos.

* load video by id
@WilHolt WilHolt mentioned this pull request May 24, 2021
@LudovicDubois
Copy link

My problem is not the same as yours.
The id I mention is the id of the HTMLElement you pass as argument. We cannot use Ids if the component is in virtual DOM. The element itself should be passed to the API, not its id.

@WilHolt
Copy link
Author

WilHolt commented May 24, 2021

yeay haha @LudovicDubois I knew that!! but still commented, I don't know what happened I'm sorry. After realizing it wasn't I deleted the comment @ @

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants