Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to esm #69

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

switch to esm #69

wants to merge 4 commits into from

Conversation

jimmywarting
Copy link

@jimmywarting jimmywarting commented Aug 31, 2021 •
edited
Loading

closes #68

maybe take the opportunity to switch to promises also in this major change?

@mcollina
Copy link
Collaborator

mcollina commented Feb 1, 2022

I would highly recommend against this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DraftProducts DraftProducts DraftProducts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to esm?
3 participants
@jimmywarting @mcollina @DraftProducts