Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: base64url support #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add: base64url support #314

wants to merge 1 commit into from

Conversation

jrschumacher
Copy link

Using string replaceAll since base64 is external base64-js.
Dependency does not yet support base64url beatgammit/base64-js#53

jrschumacher
jrschumacher commented May 17, 2022
View reviewed changes
index.js Show resolved Hide resolved
@SamuelScheit
Copy link

I also need base64url encoding support for my project,
@jrschumacher thank you for implementing it, I'll use your branch until this PR gets merged.

@SamuelScheit SamuelScheit mentioned this pull request Jun 21, 2022
Open
@Dabada
Copy link

Dabada commented Aug 31, 2022

Any news for this ? Please.

@Hedzer
Copy link

Hedzer commented Oct 16, 2022

same issue, any news?

@ChrisAntaki
Copy link

Thanks for coding this, @jrschumacher! Using it for a fork

@swetshaw
Copy link

I need base64url encoding support for my project, can we review and merge this ASAP?

@jrschumacher
Copy link
Author

It's probably not going to happen if it's been this long. Just use my branch or just wrap the base64 function in a string replace.

@TDola
Copy link

TDola commented Feb 22, 2023

Hopefully this is merged some day. It seems to work well
npm install feross/buffer#pull/314/head

dcousens
dcousens approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@dcousens dcousens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll need to resolve the CI issues before I can merge though

jrschumacher
jrschumacher commented Oct 6, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
@jrschumacher
Copy link
Author

jrschumacher commented Oct 6, 2023 •
edited
Loading

@dcousens I removed trailing spaces on line 955 of index.js

@lenkan lenkan mentioned this pull request Feb 15, 2024
Merged
@Le0X8 Le0X8 mentioned this pull request May 28, 2024
Open
@drorgl drorgl mentioned this pull request Jun 21, 2024
Merged
@jrschumacher
Copy link
Author

@dcousens still interested in taking this?

@jrschumacher
add: base64url support
f22ba44 
Using string replaceAll since base64 is external base64-js.
Dependency does not yet support base64url beatgammit/base64-js#53
@jrschumacher
Copy link
Author

I rebased with the master branch and removed my lint scripts from the package.json to reduce conflicts.

@dcousens
Copy link
Collaborator

dcousens commented Jul 24, 2024 •
edited
Loading

Thanks @jrschumacher, I'm happy to take this from here next I can, I need to check in on @chjj's pull request in #349, which might supersede this

@dcousens dcousens self-assigned this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcousens dcousens dcousens approved these changes

Assignees

@dcousens dcousens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jrschumacher @SamuelScheit @Dabada @Hedzer @ChrisAntaki @swetshaw @TDola @dcousens