Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature, ts): Support oauth client credentials flow #3578

Merged
merged 8 commits into from May 14, 2024
Merged

Conversation

amckinney
Copy link
Contributor

@amckinney amckinney commented May 8, 2024

This adds support for the OAuth client credentials flow in the TypeScript generator. The new OAuthTokenProvider automatically resolves the access token and refreshes it as needed. The resolved access token is then used as the bearer token in all client requests.

@dsinghvi
Copy link
Member

dsinghvi commented May 8, 2024

This looks great to me -- the only thing I could see us adding is some doc strings in the OAuthTokenProvider which explains some of the functionality

@amckinney amckinney marked this pull request as ready for review May 13, 2024 23:51
@amckinney amckinney requested a review from dsinghvi as a code owner May 13, 2024 23:51
Copy link
Member

@dsinghvi dsinghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the codegen looks great to me

@dsinghvi dsinghvi merged commit a910a23 into main May 14, 2024
26 checks passed
@dsinghvi dsinghvi deleted the amckinney/oauth/ts branch May 14, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants