(fix): handle allow-mulitple query parameter validation
#3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
commented
May 7, 2024
| rawType = rawType.startsWith("optional") | ||
| ? `optional<list<${rawType}>>` | ||
| : `list<${rawType}>`; | ||
| } |
There was a problem hiding this comment.
tracking that this is weird
dsinghvi
commented
May 7, 2024
| }); | ||
|
|
||
| const expectedViolations: ValidationViolation[] = []; | ||
| expect(violations).toEqual(expectedViolations); |
There was a problem hiding this comment.
the goal was to get this test case to pass which works
dsinghvi
commented
May 7, 2024
| "endpoints", | ||
| "get", | ||
| { | ||
| arrayIndex: 3, |
There was a problem hiding this comment.
lines 180-195 are incorrect, ideally the diff should be 0 here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
allow-multiplequery parameters should support list examples.Approach
Validating examples in Fern is pretty complex. So the way I approached this was to validate the query param as a list and as a non-list. If there are no errors in one of the two cases, then
fern checkpasses.If there are errors, then we list them for the
non-listcase.