Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the /send API #1

Merged
merged 51 commits into from
Oct 12, 2024
Merged

Implementation of the /send API #1

merged 51 commits into from
Oct 12, 2024

Conversation

felipet
Copy link
Owner

@felipet felipet commented Oct 12, 2024

No description provided.

Changes:
- Definition of the client object
- Definition and implementation of a client builder
- Basic unit testing of the builder
- Basic declarations of the library
For the integration tests, when using a mocked server, HTTPS needs to be
disabled.
The default integration tests for /send v3 runs against a mock server
rather than the external servery provided by Mailjet. This is much
clearner than issuing many send requests to the real API.
That kind of test is still included, but disabled by default.
@felipet felipet added the enhancement New feature or request label Oct 12, 2024
@felipet felipet self-assigned this Oct 12, 2024
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@felipet felipet merged commit 1e65a73 into main Oct 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants