Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label alignment and icon #1058

Open
wants to merge 2,460 commits into
base: master
Choose a base branch
from
Open

Label alignment and icon #1058

wants to merge 2,460 commits into from

Conversation

SamYStudiO
Copy link
Contributor

Hello Josh,

I've been working to add some alignment and icon from Label, this is something i often need from my projects and i guess it avoid some hard work using LayoutGroup.
I tried to match as best as possible your code style but in case you can't merge it i'll be glad if this may help in any way.

Thank you!

Fix of addling listener to Event.REMOVED_FROM_STAGE in DefaultPopUpManager:addPopUp
…ME_* with DEFAULT_CHILD_STYLE_NAME_*. better matches the changeover to styleNameList from nameList. old properties are deprecated and will be removed in the future.
…ME_* with DEFAULT_CHILD_STYLE_NAME_*, replaced ALTERNATE_NAME_ with ALTERNATE_STYLE_NAME_. better matches the changeover to styleNameList from nameList. old properties are deprecated and will be removed in the future.
…instead of the old 'name' naming convention)
…een() and clearScreen(), pass transition to clearScreenInternal() instead of boolean
…the component initializes. updated docs to explain that the old properties will not be reset in any way.
…eep scrolling smooth when items unexpectedly resize (references #432)
… adjust scroll position to avoid jumpy or shifting items when scrolling backgrounds while the layout is virtual with variable item dimensions (closes #432)
…ildren as a pop-up wouldn't properly set the focus manager on the children (closes #999)
…esult in the style provider being reapplied (closes #1006)
…ort would result in being unable to scroll (closes #1007)
joshtynjala and others added 28 commits December 17, 2014 11:25
…ight and maxWidth/Height into account for proper measurement
…ly dispatched on disposal because dataProvider is set to null
…s into custom header factory as a best practice
…n empty space with a color because the transparency was distracting
…ng different types of transitions wouldn't work anyway. the screen navigator enforces the rule that only one transition may be active at a time anyway
…nd for the issue where the first few frames of a transition can be skipped. the full animation is now visible even on slow mobile devices.
… special icons, style tweaks to aside elements
…e old wiki format didn't support in certain elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants