Allow customize key options #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcsonline
referenced
this pull request
Mar 7, 2021
sunaku
reviewed
Mar 7, 2021
tmux-thumbs.tmux
Outdated
| THUMBS_KEY="$(tmux show-option -gqv @thumbs-key)" | ||
| THUMBS_KEY=${THUMBS_KEY:-$DEFAULT_THUMBS_KEY} | ||
|
|
||
| tmux bind-key "${THUMBS_KEY}" run-shell -b "${CURRENT_DIR}/tmux-thumbs.sh" | ||
| tmux bind-key "${THUMBS_KEY_OPTIONS}" "${THUMBS_KEY}" run-shell -b "${CURRENT_DIR}/tmux-thumbs.sh" |
There was a problem hiding this comment.
This would send an empty (zero length string) argument to tmux by default. A small test shows tmux doesn't like it:
$ tmux bind-key "" "X" display-message hello
unknown key:
exit 1
$ p tmux bind-key "" "X" display-message hello
["tmux", "bind-key", "", "X", "display-message", "hello"]Essentially, you need to avoid sending the empty argument to tmux by default. Relaxing the quoting discipline is one way to solve this. But since you wish to maintain the quoting discipline, an explicit if-statement would also solve this:
if [ -n "${THUMBS_KEY_OPTIONS}" ]; then
tmux bind-key "${THUMBS_KEY_OPTIONS}" "${THUMBS_KEY}" run-shell -b "${CURRENT_DIR}/tmux-thumbs.sh"
else
tmux bind-key "${THUMBS_KEY}" run-shell -b "${CURRENT_DIR}/tmux-thumbs.sh"
fiThere was a problem hiding this comment.
Ok, got it. Although I'm going to try another approach because this last if is duplicating a bit the logic.
There was a problem hiding this comment.
Can you try again with the latest code?
fcsonline
force-pushed
the
feature/key-options
branch
from
09ec6f1 to
8f95d2b
Compare
Merged
|
Closing this PR because of this: #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix this: #77