Fix incorrect scan results with retry feature and -test-repetition-relaunch-enabled #21989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
When the 'test-repetition-relaunch-enabled' option is enabled, the scan output includes results from all test retries. The following is an example of a scan run with this option enabled.
From the log, tests run twice and succeeded at the end.
But the scan results combined them together.
As scan results showed 2 failures, fastlane returned with failure
Description
This change removes retry attempts and selects the best result from all retries with the minimum test failures as the final scan result, ensuring accurate scan output.
Executed 1724 tests, with 1 failures (0 unexpected) in 10.121 (10.674) seconds
Executed 1724 tests, with 0 failures (0 unexpected) in 13.318 (14.871) seconds
Testing Steps