Fix default arguments for override_status_bar #21954
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21255 -- shout out to @jeffphp who pinpoints the problem in that issue's discussion.
Snapshot's
override_status_bar
is currently broken when using default arguments. At some point,simctl
got very picky about the ISO8601 date formats it would accept, and now gives an error if no fractional seconds are given.This is easy to self-fix by supplying
override_status_bar_arguments
, but that requires digging in and understanding snapshot. And, this is a silent failure of the default override.Description
This is a 3 character change (
.iso8601
->.iso8601(1)
) that just adds 1 fractional digit to the seconds in the formatted time, and a comment about it.Testing Steps