Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship] add get_beta_app_tester_detail #21933

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mlch911
Copy link
Contributor

@mlch911 mlch911 commented Mar 25, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Add the connect api of iris/v1/apps/#{app_id}/betaAppTesterDetail.
Through this API, you can know how many new testers you can still add, and even automate the removal and addition of testers.

Description

Add the connect api of iris/v1/apps/#{app_id}/betaAppTesterDetail.
Through this API, you can know how many new testers you can still add, and even automate the removal and addition of testers.

Testing Steps

@mlch911
Copy link
Contributor Author

mlch911 commented Mar 26, 2024

The lint failed with this. But other functions in that file also named prefix with get_.

Offenses:

spaceship/lib/spaceship/connect_api/models/app.rb:390:11: C: Naming/AccessorMethodName: Do not prefix reader method names with get_.
      def get_beta_app_tester_detail
          ^^^^^^^^^^^^^^^^^^^^^^^^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant