Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit error for destination without simulator #21911

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rocketlobster
Copy link

@rocketlobster rocketlobster commented Mar 7, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

馃槶 Before:
When configuring a new target with UI tests to setup Fastlane Snapshot, it's easy to get fooled and add an unwanted "Mac" destination.
In this case, when launching fastlane snapshot, user receives a cryptic error:
Error running screenshots command - latest_simulator_version_for_device: undefined method `os_version' for nil:NilClass .

馃憤 After:
With this change, if no simulator is found for a given device, display a pretty error to show for which device, so that users can quickly understand that the destination target is wrong.

Description

Testing Steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant