Add explicit error for destination without simulator #21911
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
馃槶 Before:
When configuring a new target with UI tests to setup Fastlane Snapshot, it's easy to get fooled and add an unwanted "Mac" destination.
In this case, when launching
fastlane snapshot
, user receives a cryptic error:Error running screenshots command - latest_simulator_version_for_device: undefined method `os_version' for nil:NilClass
.馃憤 After:
With this change, if no simulator is found for a given device, display a pretty error to show for which device, so that users can quickly understand that the destination target is wrong.
Description
Testing Steps