New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] Add get app availabilities v2 request #21901
base: master
Are you sure you want to change the base?
[spaceship] Add get app availabilities v2 request #21901
Conversation
…st - the same way as in open api specs
…h longer url with services-account
question: how are you going to know which territory corresponds to a territoryAvailability? |
@shernade I took a look at the fixtures and I think that when you fetch appAvailabilities you can get territoryAvailabilities and as far as I remember |
i see that doing a call like this:
that model data seems a bit complicated to me, |
@lucgrabowski Let's get #21900 through the door first. I hope tests are passing now. Then there should be less changes here, and hopefully less warnings. Could you provide me/us with some basic steps to test/reproduce this with the Spaceship playground? More than happy to review that so we can get this PR here over the finish lines as well! Thanks for your work in the meantime :) |
#21900 |
@max-ott Thanks for reviewing and merging other PRs. I don’t have an access to computer this weekend, but I have tried merging About testing steps in Spaceship playground. I logged in to developer account, fetched Also, using a network proxy may be useful and running playground with SPACESHIP_DEBUG=1 enabled, https://github.com/fastlane/fastlane/blob/master/spaceship/docs/Debugging.md) |
I have created my own fork with all the latest commits from master and then also applied the changes introduced in this PR - when running a test App Store deployment workflow - i'm still getting pretty much the same error:
I just thought you'd like to know |
I think the problem is that you can only retrieve ( My test:
Results
|
@max-ott |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
As written in #21890, there is a need to implement a new request for app availabilities. It will allow for checking if app is available or removed from distribution.
PR should be considered after #21900 is handled.
Description
In this PR a request for app availabilities (https://developer.apple.com/documentation/appstoreconnectapi/read_app_availablity_territories) is implemented. It's a first request to
v2
version inpath
.Request is used in Pricing and Availability on AppStoreConnect.
Testing Steps
I added unit tests for models.
I also tested the request in spaceship playground.