Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly close PTY parameters to get rid of leaks that cause Pty to fail with 'Can't get Master/Slave device' error [WIP] #21831

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lacostej
Copy link
Collaborator

@lacostej lacostej commented Jan 24, 2024

While investigating #21792, I recreated issue #8258. This fixes it.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Description

Testing Steps

@lacostej lacostej changed the title Properly close PTY parameters to get rid of leaks that cause Pty to fail with 'Can't get Master/Slave device' error Properly close PTY parameters to get rid of leaks that cause Pty to fail with 'Can't get Master/Slave device' error [WIP] Jan 24, 2024
@lacostej lacostej marked this pull request as draft February 12, 2024 16:38
…ail with 'Can't get Master/Slave device' error
@lacostej lacostej force-pushed the fix/command_executor_close_resources_pty branch from 66a80b2 to df3ebda Compare February 28, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant