New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[match] import cert key profiles path args #21723
base: master
Are you sure you want to change the base?
[match] import cert key profiles path args #21723
Conversation
…ose import locations via config arguments and make UI prompting for files optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Nice improvement for the import.
also @nekrich regarding docs, can you point me in the right direction please? i'd like to add info about this here: https://github.com/fastlane/docs/blob/master/docs/generated/actions/match.md?plain=1 however the source says this doc is auto-generated... however its unclear where the bulk of the content is coming.... as the source file referenced at https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/sync_code_signing.rb has none of that content. |
Hi! How can I help move this forward? |
The majority of actions has documentation generated based on contents of actions implementation files in ruby, but sync_code_signing has a custom documentation in file: Docs update is started on release, you could check how it's generated in here: |
Hi @lucgrabowski - i'm just getting back to this PR to move it forward. Latest build again failed on doc but not sure why: https://app.circleci.com/pipelines/github/fastlane/fastlane/6347/workflows/b344c11f-ac30-41a3-887f-8f4376e0fb83/jobs/98623?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary Regarding What specific steps do I need to take to see that the additional arguments in the |
Hi! How can I help move this forward? |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
#21712
I have a need to manage profiles/certs independently in my
match
cert/key/profile repo from headless automation. I added some additional config options that lets someone specify paths to certs/keys and profiles rather than having to be prompted for them as well as import them independently from one another.Description
You can now import certs/keys and profiles independently as well as not be prompted for the paths, but via args, such as the below. Without using any of the new options, the existing behavior works the same (the user gets prompted by the UI). If you are only importing profiles but not certs, the apple connect cert import operations won't occur.
Testing Steps
See above, see unit tests.
docs
regarding the docs, i'd like to add info about this here: https://github.com/fastlane/docs/blob/master/docs/generated/actions/match.md?plain=1 however the source says this doc is auto-generated... however its unclear where the bulk of the content is coming.... as the source file referenced at https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/sync_code_signing.rb has none of that content.