Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kill kill
Arguments in favor of not supporting ruby 2.6 anymore:
Arguments in favor of keeping support for ruby 2.6:
I am in favor of deprecating ruby 2.6 support for now. We could start by adding a huge deprecation message for ruby 2.6 users or even use different notifications such as adding an extra sleep time or forcing users to set an env variable to let ruby run.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Description
Some information about stats
Here's a little script that allows to extract information about the ruby version usage based on reported issues in github:
So ruby 2.6 accounts for about 12.7% of the issues reported with a Ruby version since January 2023.
And same stats for issues from 20000 to 20999 (Feb 2022 to Jan 2023) returns 30% using 2.6 or lower.
Update
In the last six months (1st of September 2023 to end of February 2024, tickets 21495 to 21896, we have 9.4% tickets using 2.6 or lower.
Testing Steps