CMake(Linux): make "-fno-omit-frame-pointer" configurable in release …

[apocelipes]

…mode.

Starting last year, Fedora and Ubuntu began to require softwares in the repository to turn on the "-fno-omit-frame-pointer" and "-mno-omit-leaf-frame-pointer" compiler options by default. This year Arch Linux also began to make similar requirements.

Fedora: https://fedoraproject.org/wiki/Changes/fno-omit-frame-pointer
Ubuntu: https://www.phoronix.com/news/Ubuntu-Frame-Pointers-Default
Arch Linux: https://rfc.archlinux.page/0026-fno-omit-frame-pointer/

So add an option and set its default value to OFF, packagers can set to ON if they need it. This might make those packagers' lives easier.

Currently the frame pointer is only valuable under Linux so it is only enabled when the build target is Linux.

This option is also not enabled in Debug mode, for two reasons:

1. Debug mode already sets "-fno-omit-frame-pointer", that's enough.
2. Frame pointers are not only for debugging but for tools like perf and eBPF to do profiling.

Test:

Turn on the option:

Default/Turn off:

[CarterLi]

Why not CFLAGS="-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer" cmake ...

[apocelipes]

Why not CFLAGS="-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer" cmake ...

It's too long and the packager should check the whole cmakelists file to ensure the flags won't be overrode, maybe too difficult to some one (a packager not need to be a programmer).

Sometimes I also need this for profiling, so I made my life easier too. To be honest, I can't remember options like "-mno-omit-leaf-xxxx", but I can barely remember ENABLE_FRAME_POINTERS.

[apocelipes]

Using options has another benifit: users can use ccmake to select their favourite features.

[CarterLi]

Why not CFLAGS="-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer" cmake ...

It's too long and the packager should check the whole cmakelists file to ensure the flags won't be overrode, maybe too difficult to some one (a packager not need to be a programmer).

There's ninja --verbose. There are thousands of packages but I don't think they can require every package to add this kind of option.

Sometimes I also need this for profiling, so I made my life easier too. To be honest, I can't remember options like "-mno-omit-leaf-xxxx", but I can barely remember ENABLE_FRAME_POINTERS.

What if you want -mno-omit-leaf-yyyy later? Fastfetch needs to add a new option again to fulfil your personal requirements?

No.

[apocelipes]

That's not my PERSONAL requirement. THAT'S FEDORA/UBUNTU/ARCH's REQUIREMENTS.

[apocelipes]

There's ninja --verbose. There are thousands of packages but I don't think they can require every package to add this kind of option.

No, they can.

[apocelipes]

OK, seems like u never read links that I posted and only want to against me. It's wasting time.

[CarterLi]

Have you ever used CFLAGS??? CFLAGS is the standard environment variable that can be set globally, for example, in your bashrc. Both fedora and debian use helper scripts to invoke cmake. If I am the package manager, I will just set CFLAGS="-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer" in the helper script, and all packages that use the script will have the flags set.

That's not my PERSONAL requirement. THAT'S FEDORA/UBUNTU/ARCH's REQUIREMENTS.

Sometimes I also need this for profiling, so I made my life easier too. To be honest, I can't remember options like "-mno-omit-leaf-xxxx", but I can barely remember ENABLE_FRAME_POINTERS.

This is your requirements. As for now, no mantainers of fastfetch distro packages made a request of adding this kind of cmake option. ENABLE_FRAME_POINTERS is your idea and named by you. I don't think you discussed it with any real fastfetch package mantainers.

[CarterLi]

OK, seems like u never read links that I posted and only want to against me. It's wasting time.

Again, please make requests that really solve problems. Otherwise, it's wasting time. Yes.

[apocelipes]

I think you should take a look at aur or ubuntu ppa's build scripts, almost no one use CFlags=xxx cmake. This is an unusual way to set compiler flags. However, if you are living in 20 years ago may be it was not so much unusual.

But who cares, I'm not your package mantainer so that's not my business. God bless your packagers.