Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for SQLAlchemy polymorphic models #1226

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

PaleNeutron
Copy link

@PaleNeutron PaleNeutron commented Nov 26, 2024

Introduce support for SQLAlchemy polymorphic models by adjusting field defaults and handling inheritance correctly in the SQLModel metaclass. Add tests to verify functionality with polymorphic joined and single table inheritance. Refer to #36 .

@PaleNeutron PaleNeutron marked this pull request as ready for review November 26, 2024 03:26
@PaleNeutron PaleNeutron changed the title Support SQLAlchemy polymorphic models Add support for SQLAlchemy polymorphic models Nov 26, 2024
@PaleNeutron PaleNeutron changed the title Add support for SQLAlchemy polymorphic models [feature] Add support for SQLAlchemy polymorphic models Nov 26, 2024
@mmx86
Copy link

mmx86 commented Dec 2, 2024

@tiangolo
Could you please comment on whether this request has a good chance of being merged?
My team and I, being under time constraints, are currently trying to decide whether to commit to this feature already.

sqlmodel/_compat.py Outdated Show resolved Hide resolved
Co-authored-by: John Pocock <[email protected]>
@ndeybach
Copy link

We are also exploring using SQLModel in our products. This would be quite an ease of life in how we are building our stack.

@tiangolo do you have a timeline as to when could this be merged / what needs to be done ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants