✨ Migrate to latest openapi-ts #1430
Merged
+1,703
−574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick91
force-pushed
the
feature/update-openapi-ts
branch
from
c9f9875 to
ab2331d
Compare
patrick91
commented
Nov 22, 2024
| plugins: [ | ||
| { | ||
| name: "@hey-api/sdk", | ||
| // NOTE: this doesn't allow tree-shaking |
There was a problem hiding this comment.
I've left this as a note, maybe we can change this setting in future (though it would require us to change quite a bit of code 😊)
patrick91
commented
Nov 22, 2024
| @@ -8,7 +8,7 @@ | |||
| "build": "tsc && vite build", | |||
| "lint": "biome check --apply-unsafe --no-errors-on-unmatched --files-ignore-unknown=true ./", | |||
| "preview": "vite preview", | |||
| "generate-client": "openapi-ts --input ./openapi.json --output ./src/client --client axios --exportSchemas true" | |||
There was a problem hiding this comment.
all of this is now in the config above 😊
There was a problem hiding this comment.
with this we could technically remove the modify ids file, but I'd say we do that in another PR 😊
patrick91
force-pushed
the
feature/update-openapi-ts
branch
from
ab2331d to
79d3afd
Compare
alejsdev
approved these changes
Nov 25, 2024
|
Cool! Thank you 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.