Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add private, local only, API for usage in E2E tests #1429

Merged
merged 18 commits into from
Dec 2, 2024

Conversation

patrick91
Copy link
Contributor

No description provided.

@patrick91 patrick91 added the feature New feature or request label Nov 22, 2024
@patrick91 patrick91 force-pushed the feature/private-api branch 2 times, most recently from e534171 to 2ed16e0 Compare November 22, 2024 15:21
@patrick91 patrick91 changed the base branch from master to feature/update-openapi-ts November 25, 2024 11:04
@patrick91 patrick91 changed the base branch from feature/update-openapi-ts to feature/remove-modify-id-script November 25, 2024 11:49
@patrick91 patrick91 force-pushed the feature/private-api branch 4 times, most recently from 7025d31 to 2991258 Compare November 26, 2024 12:16
@@ -0,0 +1,21 @@
// @ts-ignore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alejsdev what do you think of having this?

currently without this running the build test would fail. The other option would be to ignore the test files when running build, which maybe is better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could ignore the test files while running the build :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alejsdev done! I had to make a new config file that ignores the whole test folder :)

@patrick91 patrick91 force-pushed the feature/remove-modify-id-script branch from 4e0ed8f to bda9841 Compare November 27, 2024 11:16
Base automatically changed from feature/remove-modify-id-script to master November 27, 2024 11:42
An error occurred while trying to automatically change base from feature/remove-modify-id-script to master November 27, 2024 11:42
@patrick91 patrick91 marked this pull request as ready for review November 28, 2024 10:18
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A couple of small comments.

backend/app/api/main.py Outdated Show resolved Hide resolved

assert user
assert user.email == "[email protected]"
assert user.full_name == "Pollo Listo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 🐔

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀 🐔 🎉

@tiangolo tiangolo merged commit 14129f7 into master Dec 2, 2024
15 checks passed
@tiangolo tiangolo deleted the feature/private-api branch December 2, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants