Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Handle non-existing user IDs in read_user_by_id #1396

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

saltie2193
Copy link
Contributor

Fix an issue where read_user_by_id would fail to return if the requested user ID did not exist.

  • Return 404 - Not Found when ID does not exist.
  • Request without sufficient permission will always result in 403 - Unauthorized.
  • Add tests to test requesting non-existing user IDs as superuser and normal user.

Fix an issue where `read_user_by_id` would fail to return if the requested user ID did not exist.
* Return `404 - Not Found` when ID does not exist.
* Request without sufficient permission will always result in `403 - Unauthorized`.
* Add tests to test requesting non-existing user IDs as superuser and normal user.
@alejsdev alejsdev changed the title 👷 Handle non-existing user IDs in read_user_by_id. 🐛 Handle non-existing user IDs in read_user_by_id. Oct 24, 2024
@alejsdev alejsdev added the bug Something isn't working label Oct 24, 2024
@alejsdev alejsdev changed the title 🐛 Handle non-existing user IDs in read_user_by_id. 🐛 Handle non-existing user IDs in read_user_by_id Oct 24, 2024
@berar
Copy link

berar commented Nov 7, 2024

Hello. I'd like to know why this pull request has not been approved. It is valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants