-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some container versions in Docker #1318
base: master
Are you sure you want to change the base?
Conversation
Change postgres version tag to a more recent one
Update Node and Traefik versions
Dear @alejsdev, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I would prefer to use version numbers, I added some comments inline. 🤓
docker-compose.yml
Outdated
@@ -1,7 +1,7 @@ | |||
services: | |||
|
|||
db: | |||
image: postgres:12 | |||
image: postgres:16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that Postgres has officially released version 17
four days ago. Should I stick to 16
or upgrade it to 17
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you were working on more importatn tasks (perfect SQLModel Documentation, by the way!😉), I changed it to 17
without your permission! Sorry for that. If you still wish to use 16
, just tell me to change it.
Sure Sir! 🫡 I'll push your requests in a couple of minutes. |
Change Postgres, Node, Traefik, and uvicorn-gunicorn-fastapi version tags to a more recent one. Changed branch name for my development consistency.
edit: Since uvicorn-gunicorn-fastapi is not a part of the project anymore, I changed the python version to the latest Python 3 instead of uvicorn-gunicorn-fastapi.