Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some container versions in Docker #1318

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

javadzarezadeh
Copy link

@javadzarezadeh javadzarezadeh commented Aug 27, 2024

Change Postgres, Node, Traefik, and uvicorn-gunicorn-fastapi version tags to a more recent one. Changed branch name for my development consistency.

edit: Since uvicorn-gunicorn-fastapi is not a part of the project anymore, I changed the python version to the latest Python 3 instead of uvicorn-gunicorn-fastapi.

@javadzarezadeh
Copy link
Author

Dear @alejsdev,
I'm really sorry that I changed the branch name. May you please label this PR, so that the checks become successful?

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would prefer to use version numbers, I added some comments inline. 🤓

backend/Dockerfile Outdated Show resolved Hide resolved
docker-compose.override.yml Outdated Show resolved Hide resolved
@@ -1,7 +1,7 @@
services:

db:
image: postgres:12
image: postgres:16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that Postgres has officially released version 17 four days ago. Should I stick to 16 or upgrade it to 17?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you were working on more importatn tasks (perfect SQLModel Documentation, by the way!😉), I changed it to 17 without your permission! Sorry for that. If you still wish to use 16, just tell me to change it.

frontend/Dockerfile Outdated Show resolved Hide resolved
@javadzarezadeh
Copy link
Author

Thanks! I would prefer to use version numbers, I added some comments inline. 🤓

Sure Sir! 🫡 I'll push your requests in a couple of minutes.

@github-actions github-actions bot removed the waiting label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants