Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options to mk_dataset #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

radekosmulski
Copy link

The biggest change is setting dataset to private by default (it is probably better to err in this direction, especially as you cannot make a dataset private once it has been made public)

Also, might be nice to let the user specify a slug or address the scenario where they put spaces in their title, this pr does both.

Not sure if I am using nbdev right! Also, possibly, these changes might go against the minimal spirit of this library! If so, no worries. 馃檪

@review-notebook-app
Copy link

Check out this pull request on聽 ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant