Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use grass as the replacement of dart-sass in rust plugin sass #451

Closed
wants to merge 4 commits into from

Conversation

NidMo
Copy link
Contributor

@NidMo NidMo commented Jul 1, 2023

Description:
Use grass as the replacement of dart-sass in rust plugin sass, delete sass embedded related codes

BREAKING CHANGE:
plugin option is currently not supported

Related issue (if exists):
close #278

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2023

🦋 Changeset detected

Latest commit: 807949b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farmfe/plugin-sass Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wre232114
Copy link
Member

Please add a changeset for plugin sass.

And Can we rename the current plugin-sass to plugin-sass-embedded, so we can use legacy sass plugin as fallback when there are issues with grass.

@wre232114
Copy link
Member

I solved the conflicts and opened a new PR #453 ,please just push the new PR if there are more updates.

@NidMo NidMo closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Use grass as the replacement of dart-sass in rust plugin sass
2 participants