Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rust plugin usage #1269

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: rust plugin usage #1269

wants to merge 11 commits into from

Conversation

callqh
Copy link
Member

@callqh callqh commented Apr 30, 2024

Description:
Make the rust plugin and the js plugin consistent in the way they are used, with type hints.

import react from '@farmfe/plugin-react';
import farmSassPlugin from '@farmfe/js-plugins-sass';

export default defineConfig({
  plugins: [
    react({}),
    farmSassPlugin({
      // globals: ['./src/variables.scss']
    })
  ],
});

BREAKING CHANGE:

Related issue (if exists):
close #1213

@callqh callqh added the WIP work in progress label Apr 30, 2024
Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: adcc92a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
create-farm-plugin Patch
@farmfe/plugin-react Patch
@farmfe/plugin-sass Patch
@farmfe/core Patch
@farmfe-examples/react-antd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@callqh callqh removed the WIP work in progress label Apr 30, 2024
@callqh callqh requested a review from wre232114 April 30, 2024 10:00
@@ -119,4 +119,4 @@ switch (platform) {
throw new Error(`Unsupported OS: ${platform}, architecture: ${arch}`);
}

export default binPath;
export default (options)=>[binPath,options];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would introduce break change when using the new @farmfe/plugin-react in old @farmfe/core, a new package entry should be added to avoid break change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize usage of rust plugins and js plugins
2 participants