Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use stricter socket timeout for gossip #2090

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Jun 24, 2024

Motivation

Gossip metrics indicate the worker sometimes stalls for 5 mins before receiving messages in a burst. Likely due to one or more bad peers. The default socket timeout is 5 mins, set this to 30seconds to see if it helps.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR updates the hubble package to use a stricter socket timeout for gossip communication in the gossipNodeWorker.ts file.

Detailed summary

  • Updated the socket timeout for gossip communication to be stricter (30 seconds).
  • Modified the transports configuration to include the new socket timeout settings.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label Jun 24, 2024
Copy link

changeset-bot bot commented Jun 24, 2024

🦋 Changeset detected

Latest commit: 3039ad0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 11:07pm

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.48%. Comparing base (1880070) to head (3039ad0).
Report is 205 commits behind head on main.

Files Patch % Lines
apps/hubble/src/network/p2p/gossipNodeWorker.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2090       +/-   ##
===========================================
- Coverage   74.05%   45.48%   -28.58%     
===========================================
  Files          99      140       +41     
  Lines        9425    22511    +13086     
  Branches     2097     7970     +5873     
===========================================
+ Hits         6980    10239     +3259     
- Misses       2327    10663     +8336     
- Partials      118     1609     +1491     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu merged commit b150e90 into farcasterxyz:main Jun 24, 2024
8 of 10 checks passed
@sanjayprabhu sanjayprabhu deleted the libp2p_timeout branch June 24, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants