Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure we run yarn postinstall script for production build #2089

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

sds
Copy link
Member

@sds sds commented Jun 24, 2024

Motivation

We were still missing the patch in production.

Change Summary

Ensure we run postinstall in production as well.

Merge Checklist

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on optimizing the Docker build process by adding a yarn postinstall step after installing production dependencies.

Detailed summary

  • Added yarn postinstall step after installing production dependencies in the Dockerfile.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:54pm

Copy link

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: c89cdf7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sds sds changed the title Ensure we run yarn postinstall script for production build fix: Ensure we run yarn postinstall script for production build Jun 24, 2024
@sds sds added the t-bug A fix for a bug with the current system label Jun 24, 2024
@sds sds enabled auto-merge (squash) June 24, 2024 17:54
@sds sds merged commit 2e07791 into main Jun 24, 2024
8 checks passed
@sds sds deleted the sds/post-install branch June 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant