test error updates

fafo · Sep 3, 2017 · d3cbeb9 · d3cbeb9
1 parent 9748255
commit d3cbeb9
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 5 deletions.
diff --git a/src/db/migrations/20170826111515_create_users_table.js b/src/db/migrations/20170826111515_create_users_table.js
@@ -1,6 +1,6 @@
 //I only want migrations, rollbacks, and seeds to run when the NODE_ENV is specified
 //in the knex seed/migrate command. Knex will error out if it is not specified.
-if (!process.env.NODE_ENV) { return; }
+if (!process.env.NODE_ENV) { throw new Error('NODE_ENV not set') }
 
 exports.up = function(knex, Promise) {
     return knex.schema.createTable('users', function(table) {

diff --git a/src/db/migrations/20170826132549_create_refresh_token_table.js b/src/db/migrations/20170826132549_create_refresh_token_table.js
@@ -1,6 +1,6 @@
 //I only want migrations, rollbacks, and seeds to run when the NODE_ENV is specified
 //in the knex seed/migrate command. Knex will error out if it is not specified.
-if (!process.env.NODE_ENV) { return; }
+if (!process.env.NODE_ENV) { throw new Error('NODE_ENV not set') }
 
 exports.up = function(knex, Promise) {
     return knex.schema.createTable('refresh_tokens', function(table) {

diff --git a/src/db/migrations/20170826132806_create_notes_table.js b/src/db/migrations/20170826132806_create_notes_table.js
@@ -1,6 +1,6 @@
 //I only want migrations, rollbacks, and seeds to run when the NODE_ENV is specified
 //in the knex seed/migrate command. Knex will error out if it is not specified.
-if (!process.env.NODE_ENV) { return; }
+if (!process.env.NODE_ENV) { throw new Error('NODE_ENV not set') }
 
 exports.up = function(knex, Promise) {
     return knex.schema.createTable('notes', function(table) {

diff --git a/src/db/seeds/dev/seed_notes.js b/src/db/seeds/dev/seed_notes.js
@@ -1,6 +1,6 @@
 //I only want migrations, rollbacks, and seeds to run when the NODE_ENV is specified
 //in the knex seed/migrate command. Knex will error out if it is not specified.
-if (!process.env.NODE_ENV) { return; }
+if (!process.env.NODE_ENV) { throw new Error('NODE_ENV not set') }
 
 const faker = require('faker')
 

diff --git a/src/db/seeds/dev/seed_users.js b/src/db/seeds/dev/seed_users.js
@@ -1,6 +1,6 @@
 //I only want migrations, rollbacks, and seeds to run when the NODE_ENV is specified
 //in the knex seed/migrate command. Knex will error out if it is not specified.
-if (!process.env.NODE_ENV) { return; }
+if (!process.env.NODE_ENV) { throw new Error('NODE_ENV not set') }
 
 const faker = require('faker')
 const bcrypt = require('bcrypt')

diff --git a/tests/test.js b/tests/test.js
@@ -1,3 +1,6 @@
+//Only run tests if we've specifically set NODE_ENV to testing
+if (process.env.NODE_ENV !== 'testing') { throw new Error('NODE_ENV not set') }
+
 //This starts the app up
 import { server } from '../app'