Mspatz/docker windows #33
Conversation
Buck passes the include path for python like with /external:I (I think because the python target is a prebuilt_cxx_library?), which is a compiler error if /external:Wn is not also passed. I susped this error is new in VS2019 but have not verified that. see: https://docs.microsoft.com/en-us/cpp/build/reference/external-external-headers-diagnostics
|
Hi @mmmspatz! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you, mmmspatz, for contributing our first Windows Docker file! If you can review the Facebook CLA Check, we could then starting merging your changes after review. |
| @@ -0,0 +1,31 @@ | |||
| FROM mcr.microsoft.com/dotnet/framework/runtime:4.8-windowsservercore-ltsc2019 | |||
There was a problem hiding this comment.
If an github action can be added, that would be even better; in that case, for future main branch changes, your Windows dockerfile setup will be automatically checked. Examples can be found here: https://github.com/facebookresearch/labgraph/tree/main/.github/workflows
This PR adds
Dockerfile.Windows, which is modeled after the mainDockerfile. Building the container builds labgraph for Windows (using vs2019), installs it, and creates a wheel. The wheel can then be copied out of the resulting image for distribution.The second to last commit adds compiler flags for an optimized build. This causes some tests to fail, so the last commit disables those tests. Interested in comment on this.
Depends on #32