Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioCraft CLI - MusicGen Implemented [DRAFT PR] #119

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

OmarMacMa
Copy link

Description

Creation of the Command-Line Interface to interact with music generation based on text descriptions. The feature provides options to the user to specify the duration of the output music, use a batch file for multiple descriptions, specify the model to be used, and indicate the name of the output file for music generation using MusicGen models.

Fixes: A contribution for the #116

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing

To verify the new feature a test was created in the /extensions/labgraph_audiogen/tests/ folder. To succesfully run this test it is needed to have the Command installed, instalation is described on the /extensions/labgraph_audiogen/README.md. Also, this test was added to the GitHub Actions.

  • Test A: Runs a description with specific output, duration and model

  • Unit Test / Integration Test (UT/IT) execution results: test passed

Checklist:

  • Have you added tests that prove your fix is effective or that this feature works?
  • New and existing unit tests pass locally with these changes?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@facebook-github-bot
Copy link

Hi @OmarMacMa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@OmarMacMa OmarMacMa changed the title AudioCraft CLI - MusicGen Implemented AudioCraft CLI - MusicGen Implemented [DRAFT PR] Nov 17, 2023
@OmarMacMa OmarMacMa marked this pull request as draft November 17, 2023 18:35
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 17, 2023
@OmarMacMa OmarMacMa marked this pull request as ready for review November 27, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants