Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioGen - Implemented Audio Generation [DRAFT PR] #117

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

Nate8888
Copy link

@Nate8888 Nate8888 commented Nov 3, 2023

Description

This PR adds CLI functionality to Audiocraft's AudioGen model to generate audio based on the provided descriptions. The changes provide options to the user to specify the duration of the output audio, use a batch file for multiple descriptions, specify the model to be used, and indicate the name of the output file.

Fixes Initial Contribution to #116

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

To validate the changes, the script was executed with various options. Here are the validation/testing results:

  • Test A - Single Description, Default Settings

  • Unit Test / Integration Test (UT/IT) execution results: All tests passed successfully.

Checklist:

  • Have you added tests that prove your fix is effective or that this feature works?
  • New and existing unit tests pass locally with these changes?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@facebook-github-bot
Copy link

Hi @Nate8888!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Nate8888 Nate8888 marked this pull request as draft November 3, 2023 17:30
Copy link
Contributor

@jfResearchEng jfResearchEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good to me. Just some minor changes needed for ease of user/reader.

@jfResearchEng
Copy link
Contributor

Please also sign Contributor License Agreement so that the code can be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants