-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate circleci worklfows to github actions #7974
Migrate circleci worklfows to github actions #7974
Conversation
✅ Deploy Preview for meta-velox canceled.
|
Thanks @robandpdx for this work. Please give us a day or so to verify that this works. |
This is great thanks, I'll have a look soon, we can probably unify the fuzzer stuff with the existing @robandpdx I see we have access to the new m1 runners, very nice! I think the fuzzer job is the only one using the 32core runner and we can probably downgrade that (we have done that with the scheduled runs already see #7842 ). |
@assignUser No objections to pushing to this PR or my branch. My fork is public and I've added you as a collaborator there. It makes sense to downgrade jobs to a smaller runners if possible, for cost control. I'm happy to help reorganize stuff if needed with some direction from folks in the know here. Just let me know how I can help. |
@robandpdx Thanks for your work. We have discussed offline and will consolidate and rework the jobs to remove redundancies and make better use of gha capabilities. Therefor we are going to split this into multiple PRs (as well as for reviewability :) ). You have some cool ideas here that I am going to reuse in the reworked builds, would you like to be pinged on those? I would appreciate your experience but I understand if you don't have the bw. |
@assignUser Sure! I'm happy to help. |
@assignUser: AFAICT all CircleCI workflows have been migrated to GitHub and all that remains is a "noop" workflow. Can we delete that workflow and disable CircleCI? (and close this PR?) |
@bigfootjon I plan to do disable CCI by Friday, we just migrated all this and wanted to be sure there are no regressions before turning off CCI. |
But we can close this PR immediately :) |
This pull request converts the CircleCI workflows to GitHub actions workflows.
The GitHub actions workflows need runner groups with larger runners configured for the organization.
The following runner group is needed:
For my testing, I have these runner groups populated with the following runners:
Issues
There are issue with some of the workflow that someone smarter than me needs to address.
linux-pr-fuzzer-run
This appears to fail getting the merge base. I'm not sure why this is happening.
linux-adapters
The error is...
https://fburl.com/workplace/f6mz6tmw