fix(json_parse): Json_parse to ignore invalid unicode escape sequences #12086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68176965 |
✅ Deploy Preview for meta-velox canceled.
|
kgpai
changed the title
kgpai
changed the title
kgpai
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D68176965 |
…ences (facebookincubator#12086) Summary: Certain improperly escaped unicode points like \uDE2Dau throw in json_parse. This happens in simdjson since these are invalid unicode escape sequences (i.e without the surrogate pairs). As Presto java ignores this, we add similar support in Velox. ``` SELECT json_parse(x) from (values '"\uDE2Dau"') t(x); -- Returns "\uDE2Dau" in java but throws in Velox ``` Reviewed By: kevinwilfong Differential Revision: D68176965
kgpai
force-pushed
the
export-D68176965
branch
from
feb8a27 to
11d5659
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68176965 |
|
This pull request has been merged in 97b64a4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Certain improperly escaped unicode points like \uDE2Dau throw in json_parse. This happens in simdjson since these are invalid unicode escape sequences (i.e without the surrogate pairs). As Presto java ignores this, we add similar support in Velox.
Differential Revision: D68176965