refactor(cache): Clean up redundant code #12024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
✅ Deploy Preview for meta-velox canceled.
|
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 6, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
a0bd3c2 to
ca90133
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
kewang1024
reviewed
Jan 7, 2025
zacw7
force-pushed
the
export-D67868731
branch
from
ca90133 to
4ea1cd5
Compare
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 8, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Differential Revision: D67868731
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 10, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
4ea1cd5 to
129d490
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
xiaoxmeng
approved these changes
Jan 10, 2025
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 10, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
129d490 to
75e9e17
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 10, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
75e9e17 to
2fdc1c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 10, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
2fdc1c1 to
d0e7dc8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 13, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
5bc428f to
0188c38
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 13, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
0188c38 to
be5c265
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 13, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
be5c265 to
c021f12
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
zacw7
force-pushed
the
export-D67868731
branch
from
c021f12 to
066154f
Compare
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 14, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 14, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
066154f to
64e6400
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 14, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
64e6400 to
9076f41
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Jan 14, 2025
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
9076f41 to
6a8177b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
Summary: Refactor read checkpoint code and consolidate duplicate file clean up. Reviewed By: xiaoxmeng Differential Revision: D67868731
zacw7
force-pushed
the
export-D67868731
branch
from
6a8177b to
15f3acc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67868731 |
|
This pull request has been merged in f112e88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Refactor read checkpoint code and consolidate duplicate file clean up.
Differential Revision: D67868731