refactor: Refactor CompactRow and UnsafeRow serializer and deserializer #11840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
jinchengchenghh
commented
Dec 12, 2024
| void clear() override {} | ||
|
|
||
| protected: | ||
| virtual void serializeRanges( |
There was a problem hiding this comment.
After this PR, we can unify serializeRanges #11206
xiaoxmeng
approved these changes
Dec 13, 2024
velox/serializers/RowSerializer.h
Outdated
| template <class Serializer> | ||
| class RowSerializer : public IterativeVectorSerializer { | ||
| public: | ||
| explicit RowSerializer(StreamArena* streamArena) |
There was a problem hiding this comment.
why not directly pass pool here since we don't hold the stream arena?
velox/serializers/RowSerializer.h
Outdated
| const std::vector<vector_size_t>& /*rowSize*/) { | ||
| size_t offset = 0; | ||
| for (auto& range : ranges) { | ||
| for (auto i = range.begin; i < range.begin + range.size; ++i) { |
xiaoxmeng
approved these changes
Dec 13, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in aa59678. |
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 14, 2024
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…er (facebookincubator#11840) Summary: Pull Request resolved: facebookincubator#11840 Reviewed By: miaoever, tonyxug Differential Revision: D67184706 Pulled By: xiaoxmeng fbshipit-source-id: e25561aa184c3798347e57c69f50ac75d1226a32
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: A follow-up fix PR for facebookincubator#11840 Pull Request resolved: facebookincubator#11858 Reviewed By: spershin Differential Revision: D67224012 Pulled By: zacw7 fbshipit-source-id: 49398f6c48aeb5876c80867c819e45fbf651c3db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.