fix(json_parse): Tape failure due to out of bounds ':' #11831
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
kgpai
force-pushed
the
export-D67108827
branch
from
9f42aa6 to
8b48b9f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67108827 |
|
This pull request was exported from Phabricator. Differential Revision: D67108827 |
kgpai
pushed a commit
to kgpai/velox-1
that referenced
this pull request
Dec 11, 2024
Summary: SIMDJSON fails with a tape failure when if a ':' immediately follows the end of a \" when parsing even though ':' is outside the range of the input. This can happen if the previous string had a ':' at just the right location as we dont clear the buffer when processing strings. Fixes T210222818 . Differential Revision: D67108827
kgpai
force-pushed
the
export-D67108827
branch
from
8b48b9f to
7b9ec81
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67108827 |
kgpai
changed the title
kgpai
changed the title
amitkdutta
approved these changes
Dec 11, 2024
Summary: SIMDJSON fails with a tape failure when if a ':' immediately follows the end of a \" when parsing even though ':' is outside the range of the input. This can happen if the previous string had a ':' at just the right location as we dont clear the buffer when processing strings. Fixes T210222818 . Reviewed By: amitkdutta Differential Revision: D67108827
kgpai
force-pushed
the
export-D67108827
branch
from
7b9ec81 to
b8c0cfa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67108827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: SIMDJSON fails with a tape failure when if a ':' immediately follows the end of a " when parsing even though ':' is outside the range of the input. This can happen if the previous string had a ':' at just the right location as we dont clear the buffer when processing strings. Fixes T210222818 .
Differential Revision: D67108827