-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(planbuilder): Accept schema for tableWriter() #11829
Open
pedroerp
wants to merge
1
commit into
facebookincubator:main
Choose a base branch
from
pedroerp:export-D67102795
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Dec 11, 2024
✅ Deploy Preview for meta-velox canceled.
|
This pull request was exported from Phabricator. Differential Revision: D67102795 |
Yuhta
approved these changes
Dec 11, 2024
xiaoxmeng
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedroerp LGTM. Thanks!
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Dec 12, 2024
…#11829) Summary: When creating a TableWriter node, allowing the client to specify a schema different from the default (the output of the previous operator). Reviewed By: Yuhta Differential Revision: D67102795
pedroerp
force-pushed
the
export-D67102795
branch
from
December 12, 2024 00:55
9c7988e
to
f7ee62f
Compare
This pull request was exported from Phabricator. Differential Revision: D67102795 |
…#11829) Summary: When creating a TableWriter node, allowing the client to specify a schema different from the default (the output of the previous operator). Reviewed By: Yuhta Differential Revision: D67102795
pedroerp
force-pushed
the
export-D67102795
branch
from
December 12, 2024 01:57
f7ee62f
to
1b3e369
Compare
This pull request was exported from Phabricator. Differential Revision: D67102795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When creating a TableWriter node, allowing the client to specify a
schema different from the default (the output of the previous operator).
Differential Revision: D67102795