refactor(parquet): Move arrow RleEncodingInternal to common #11795
+77
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
wypb
force-pushed
the
move_arrow_lib
branch
3 times, most recently
from
8a43928 to
15e25de
Compare
|
@wypb Let's also change the variable names to the Velox coding convention which uses camel case. Thanks. |
wypb
force-pushed
the
move_arrow_lib
branch
6 times, most recently
from
c19fa13 to
06e0896
Compare
|
Hi @majetideepak I have made changes according to the comments. Please help me take another look when you have time. Thank you! |
|
Hi @majetideepak Thank you for your review. I have addressed all the comments. |
|
@wypb CI is failing. Can you take a look? |
wypb
force-pushed
the
move_arrow_lib
branch
5 times, most recently
from
9669b1d to
3a2e249
Compare
|
@wypb Is the MacOS build failure related? |
|
@majetideepak The error is Linking lib/libvelox.dylib. I’m not sure if it’s related to the current PR. I’m still looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR: #11711
Summary:
Both Parquet reader and writer depend on RleEncodingInternal.
This currently resides in parquet/writer/arrow which introduces a dependency of the writer to the reader.
No functional changes.
CC: @majetideepak @pedroerp