Let arbitrator system use nano second #11415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
tanjialiang
force-pushed
the
nano_sec
branch
4 times, most recently
from
e26f573 to
77a3b28
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
approved these changes
Nov 4, 2024
| @@ -95,28 +95,28 @@ class ArbitrationOperation { | |||
|
|
|||
| /// Returns the remaining execution time for this operation before time out. | |||
| /// If the operation has already finished, this returns zero. | |||
| size_t timeoutMs() const; | |||
| int64_t timeoutNs() const; | |||
There was a problem hiding this comment.
uint64_t ? shall we be consistent? I saw Timer.h use uint64_t
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Some tests are flaky because current milisecond is too coarse. And some operations run sub-milisecond. We want to change it to nanosecond across the board to reduce this flakiness
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tanjialiang merged this pull request in 62b0a12. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nano seconds in arbitrator system to avoid flakiness in time dependent tests.