Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify and utilize NPROC variable for Linux setup scripts #11366

Closed
wants to merge 1 commit into from

Conversation

czentgr
Copy link
Collaborator

@czentgr czentgr commented Oct 28, 2024

This PR unifies the usage of the number of parallel build threads by using the defined NPROC variable. This variable is populated by the same mechanisms on macOS and Linux ensuring consistency and sharable functions for the script refactor.

This PR unifies the usage of the number of parallel build threads by using
the defined NPROC variable. This variable is populated by the same
mechanisms on macOS and Linux ensuring consistency and sharable functions
for the script refactor.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2024
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for meta-velox ready!

Name Link
🔨 Latest commit 15bb7f0
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/672011ec0484390008dd45b8
😎 Deploy Preview https://deploy-preview-11366--meta-velox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@majetideepak majetideepak marked this pull request as ready for review October 29, 2024 15:40
@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Oct 29, 2024
@facebook-github-bot
Copy link
Contributor

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pedroerp merged this pull request in ca8dba4.

Copy link

Conbench analyzed the 1 benchmark run on commit ca8dba41.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants