Add HashJoinReplayer #11271
Closed
Add HashJoinReplayer #11271
+702
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
duanmeng
requested review from
xiaoxmeng
and removed request for
majetideepak and
assignUser
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
reviewed
Oct 17, 2024
duanmeng
force-pushed
the
join_replay
branch
2 times, most recently
from
c0a056b to
98696c1
Compare
xiaoxmeng
reviewed
Oct 17, 2024
duanmeng
force-pushed
the
join_replay
branch
7 times, most recently
from
69e87a7 to
7d5a051
Compare
xiaoxmeng
reviewed
Oct 25, 2024
duanmeng
force-pushed
the
join_replay
branch
4 times, most recently
from
4dcada9 to
3ac8fe5
Compare
duanmeng
force-pushed
the
join_replay
branch
7 times, most recently
from
a66f733 to
101c528
Compare
xiaoxmeng
reviewed
Nov 1, 2024
duanmeng
force-pushed
the
join_replay
branch
3 times, most recently
from
a2bc745 to
6747743
Compare
xiaoxmeng
approved these changes
Nov 1, 2024
| using namespace facebook::velox::common::hll; | ||
|
|
||
| namespace facebook::velox::tool::trace::test { | ||
| class HashJoinReplayerTest : public HiveConnectorTestBase { |
There was a problem hiding this comment.
Consider to have TraceReplayTestBase : public HiveConnectorTestBase in followup to handle the common env setup. Thanks!
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
duanmeng
force-pushed
the
join_replay
branch
3 times, most recently
from
b7540f8 to
aa07ab1
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
zuyu
reviewed
Nov 4, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in 1e22de8. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HashJoinReplayer to support replaying of hash join, and add
a valid list of operator types supporting tracing.
Part of #9668