-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use envvar for DuckDB version in setup script #11207
Use envvar for DuckDB version in setup script #11207
Conversation
✅ Deploy Preview for meta-velox canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensible change but please also add the change to the other setup scripts aswell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@assignUser this is my first PR in velox, may I ask how a PR is merged? For I foud all PRs are closed but not merged in github, thanks. |
@JackyWoo as this is a Meta project the code actually lives in the Meta monorepo. So PRs from github get reviewed and tested here but a meta employee has to import them into the internal monorepo. Once that is done and has passes checks it gets exported into the facebookincubator/velox repo by facebookbot and the PR is closed. It looks weird in your gh activity but the code does get merged properly ^^ It's a bit of a process and we are working towards are more streamlined open-source first approach but that's stll a while of. |
@assignUser really thanks. |
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Changelog
Make duckdb version an versiable