Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use envvar for DuckDB version in setup script #11207

Closed

Conversation

JackyWoo
Copy link
Contributor

@JackyWoo JackyWoo commented Oct 9, 2024

Changelog

Make duckdb version an versiable

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit b11a35f
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6707516faeff48000821c94e

@assignUser assignUser changed the title Make duckdb version an versiable Use envvar for DuckDB version in setup script Oct 10, 2024
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible change but please also add the change to the other setup scripts aswell.

@JackyWoo JackyWoo requested a review from assignUser October 11, 2024 02:38
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@assignUser assignUser added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Oct 11, 2024
@JackyWoo
Copy link
Contributor Author

JackyWoo commented Oct 11, 2024

@assignUser this is my first PR in velox, may I ask how a PR is merged? For I foud all PRs are closed but not merged in github, thanks.

@assignUser
Copy link
Collaborator

@JackyWoo as this is a Meta project the code actually lives in the Meta monorepo. So PRs from github get reviewed and tested here but a meta employee has to import them into the internal monorepo. Once that is done and has passes checks it gets exported into the facebookincubator/velox repo by facebookbot and the PR is closed. It looks weird in your gh activity but the code does get merged properly ^^

It's a bit of a process and we are working towards are more streamlined open-source first approach but that's stll a while of.

@JackyWoo
Copy link
Contributor Author

@assignUser really thanks.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in f698208.

Copy link

Conbench analyzed the 1 benchmark run on commit f6982089.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants