Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo of PYTHON_VENV variable #11185

Closed

Conversation

majetideepak
Copy link
Collaborator

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2024
@majetideepak majetideepak requested a review from kgpai October 7, 2024 10:02
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 63c413e
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6703b1a0013c72000868c43e

@majetideepak majetideepak requested a review from czentgr October 7, 2024 10:08
@majetideepak majetideepak changed the title Fix typo in PYTHON_VENV variable Fix typo of PYTHON_VENV variable Oct 7, 2024
@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Oct 7, 2024
@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xiaoxmeng
Copy link
Contributor

@majetideepak can you check if the build failure are related? Thanks!

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in a62a3aa.

Copy link

Conbench analyzed the 1 benchmark run on commit a62a3aa2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@majetideepak majetideepak deleted the fix-python-venv branch October 17, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants