-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable decimal fuzzer test in experimental workflow #10948
Conversation
✅ Deploy Preview for meta-velox canceled.
|
@kgpai @assignUser This PR enables decimal fuzzer test experimentally. Would you like to take a review? Thanks. |
It's oom killed, you probably need to switch the runner too 16-core-ubuntu as we have in |
7383e0e
to
8471959
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it already found some issues ^^
@assignUser Thanks for your review. Just want to clarify that the two failures are related to #10871 and #10989, after the change from user error to runtime error, but they are not related to the decimal type. |
@kgpai @majetideepak Would you like to take a review? Thanks. |
@assignUser @kgpai @majetideepak Could we merge this PR if no further comment? Thanks for your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @assignUser can you make a final pass? Thanks.
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kagamiori merged this pull request in 97bf4db. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Enables experimental fuzzer test with decimal type enabled. We can turn it on
for the nightly and CI jobs once we get a few green runs.