Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable decimal fuzzer test in experimental workflow #10948

Closed
wants to merge 1 commit into from

Conversation

rui-mo
Copy link
Collaborator

@rui-mo rui-mo commented Sep 9, 2024

Enables experimental fuzzer test with decimal type enabled. We can turn it on
for the nightly and CI jobs once we get a few green runs.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2024
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 5750d89
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66f4d93e4460990008fe634e

@rui-mo
Copy link
Collaborator Author

rui-mo commented Sep 10, 2024

@kgpai @assignUser This PR enables decimal fuzzer test experimentally. Would you like to take a review? Thanks.

@assignUser
Copy link
Collaborator

It's oom killed, you probably need to switch the runner too 16-core-ubuntu as we have in scheduled.yml

@rui-mo rui-mo force-pushed the wip_dec_ci branch 3 times, most recently from 7383e0e to 8471959 Compare September 14, 2024 01:04
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it already found some issues ^^

@rui-mo
Copy link
Collaborator Author

rui-mo commented Sep 18, 2024

@assignUser Thanks for your review. Just want to clarify that the two failures are related to #10871 and #10989, after the change from user error to runtime error, but they are not related to the decimal type.

@rui-mo
Copy link
Collaborator Author

rui-mo commented Sep 20, 2024

@kgpai @majetideepak Would you like to take a review? Thanks.

@rui-mo
Copy link
Collaborator Author

rui-mo commented Sep 25, 2024

@assignUser @kgpai @majetideepak Could we merge this PR if no further comment? Thanks for your help.

Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @assignUser can you make a final pass? Thanks.

@assignUser assignUser added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Sep 26, 2024
@facebook-github-bot
Copy link
Contributor

@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kagamiori merged this pull request in 97bf4db.

Copy link

Conbench analyzed the 1 benchmark run on commit 97bf4db8.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants