Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold support for Tracing by jsinspector #48836

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Jan 21, 2025

Summary: # Changelog: [Internal]

Differential Revision: D68327630

hoxyq added 2 commits January 21, 2025 04:34
Summary:
# Changelog: [Internal]

This is the pre-requisite before adding a formatter for conversion from Hermes format-agnostic API for JavaScript samples to Trace Events.

This struct will probably be used a lot around this module and big enough for a separate header.

Differential Revision: D68104202
Summary:
Pull Request resolved: facebook#48795

# Changelog: [Internal]

Splitting `PerformanceTracer::stopTracingAndCollectEvents()` into 2 separate methods.

Once we add logic for starting and stopping tracing on `InstanceAgent`:
- We would need to stop tracing everywhere synchronously
- Populate data sources in `PerformanceTracer`, like JavaScript samples
- Collect all events from different data sources in one payload via `PerformanceTracer::collectEvents()`

Differential Revision: D68331485
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68327630

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68327630

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 22, 2025
Summary:
Pull Request resolved: facebook#48836

# Changelog: [Internal]

Differential Revision: D68327630
Summary:
Pull Request resolved: facebook#48836

# Changelog: [Internal]

Differential Revision: D68327630
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68327630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants