introduce Fantom.dispatchNativeStateUpdate #48802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: changelog: [internal] Adds new method `dispatchNativeEvent` to Fantom give option to dispatch fake native events. The API is expanded in subsequent diffs. The version introduced in this diff supports only dispatching event without payload and without any options. Differential Revision: D68331986
Summary: changelog: [internal] Add payload argument to Fantom.dispatchNativeEvent. For example, in `TextInput.onChange` event, new value of input field must be present in the event payload. Reviewed By: rubennorte Differential Revision: D68410469
Summary: changelog: [internal] add event category argument to Fantom.dispatchNativeEvent. This gives tests option to control whether an event is continuous, discrete etc. Differential Revision: D68413879
Summary: changelog: [internal] Adds isUnique option to Fantom.dispatchNativeEvent. isUnique controls whether only the last event of the same type and target is dispatched to JavaScript or all events are queued and dispatched. Differential Revision: D68416157
Summary: changelog: [internal] Introduces a mechanism to fake C++ state update from JavaScript for testing in Fantom. One problem with approach in this diff is use of folly::dynamic. To make it work, folly::dynamic is no longer Android only. iOS and other platforms are not paying extra cost for folly::dynamic being included because they all already have it. The alternative approach would be to introduce a component specific interface to NativeFantom module so state in ScrollView, TextInput and Image can be manipulated. On the flip side, this is a very flexible solution. In the future, we might want to introduce Fantom wrappers around ScrollView and TextInput that would be flow typed in tests. They would also make sure that changing ScrollView.contentOffset always triggers both onScroll and state update. Differential Revision: D68418535
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68418535 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Introduces a mechanism to fake C++ state update from JavaScript for testing in Fantom.
One problem with approach in this diff is use of folly::dynamic. To make it work, folly::dynamic is no longer Android only.
iOS and other platforms are not paying extra cost for folly::dynamic being included because they all already have it.
The alternative approach would be to introduce a component specific interface to NativeFantom module so state in ScrollView, TextInput and Image can be manipulated. On the flip side, this is a very flexible solution.
In the future, we might want to introduce Fantom wrappers around ScrollView and TextInput that would be flow typed in tests. They would also make sure that changing ScrollView.contentOffset always triggers both onScroll and state update.
Differential Revision: D68418535