fix: fix @react-native-community/cli-platform-*
packages not being found in monorepos
#47308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix
@react-native-community/cli-platform-*
packages not being found in monorepos.Note that we are making the assumption that
process.cwd()
returns the project root. This is the same assumption that@react-native-community/cli
makes. Specifically,findProjectRoot()
has an optional argument that defaults toprocess.cwd()
:findProjectRoot()
loadConfig()
loadConfig()
gets called fromsetupAndRun()
, also without project root setAs far as I can see, the project root argument is only ever used in tests.
Changelog:
[GENERAL] [FIXED] - Fix
@react-native-community/cli-platform-*
packages not being found in monoreposTest Plan:
react-native
to 0.76 microsoft/rnx-kit#3409@react-native-community/cli
not being found in monorepos #47304@react-native-community/cli-platform-*
packages not being found in monorepos #47308react-native config
insidepackages/test-app
projects
is populatedBefore:
After: