Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating eslint packages to flat config file #43959

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MCanhisares
Copy link
Contributor

@MCanhisares MCanhisares commented Apr 8, 2024

Summary:

Implements eslint flat config file support

Changelog:

[GENERAL] [ADDED] - Adding support for Flat Config files

Test Plan:

Run lint on a reproducer with the eslint config changes
Reproducer example: https://github.com/MCanhisares/eslint-flat-upgrade

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2024
@MCanhisares MCanhisares changed the title Updating eslint packages to flat file Updating eslint packages to flat config file Apr 8, 2024
@analysis-bot
Copy link

analysis-bot commented Apr 8, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,558,636 +0
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,928,758 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3f17c8b
Branch: main

@MCanhisares MCanhisares marked this pull request as ready for review April 8, 2024 21:02
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 8, 2024
@jafar-jabr
Copy link

@MCanhisares Is there any chance that this will be merged soon ?

@MCanhisares
Copy link
Contributor Author

MCanhisares commented May 11, 2024

@cortinico what do we have to do to get this ready for merge?

Edit: To add more context, the JS tasks are failing because the eslint server is using the latest version of this package which should be ready for the new config format. Should we fix these issues in this PR? Or open another PR to handle the changes to the main proj?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants