Remove -custom mode from Dune
#776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now deprecated and breaks the bytecode build if one opts in for it. Signed-off-by: Vasilis Themelis <[email protected]>
|
@alexkassil has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
alexkassil
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
this lgtm! I will try to get this merged in. #762 (comment) this looks awesome btw, I'll benefit from using a debugger instead of just print statements.
|
@alexkassil merged this pull request in bc2f70f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This is now deprecated and breaks the bytecode build if one opts in for it.
Specifically, removing this allows me to fix ocsigen/lwt#999 when building in bytecode.